Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

Sign up for GitHub

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Jump to bottom

deps: upgrade npm to 9.2.0 #45780

Merged
merged 1 commit into from Dec 9, 2022
Merged

deps: upgrade npm to 9.2.0 #45780

merged 1 commit into from Dec 9, 2022

Conversation

npm-cli-bot
Copy link
Contributor

9.2.0 (2022-12-07)

Features

Bug Fixes

Dependencies

@nodejs-github-bot nodejs-github-bot added dont-land-on-v14.x fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry. labels Dec 7, 2022
@github-actions
Copy link
Contributor

github-actions bot commented Dec 7, 2022

Fast-track has been requested by @nodejs-github-bot. Please 👍 to approve.

@anonrig anonrig added the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@github-actions github-actions bot removed the request-ci Add this label to start a Jenkins CI on a PR. label Dec 8, 2022
@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48351/

@targos
Copy link
Member

targos commented Dec 8, 2022

If I counted correctly, this introduces 8 identical copies of minipass@v3. Is that expected?

@lukekarrys
Copy link
Member

If I counted correctly, this introduces 8 identical copies of minipass@v3. Is that expected?

@targos yes that is correct. We updated to minipass@4 across all of our dependencies, so that version is now deduped to the top of node_modules but that leaves 8 other dependencies still using minipass@3. We have a plan to send PRs to those dependencies to update to minipass@4 (which should be an easy update) to once again dedupe to a single version of minipass hopefully within the next couple releases. I did measure the release and and this increased the bundle size about 14kb which is the main tradeoff with our approach.

@nodejs-github-bot
Copy link
Collaborator

CI: https://ci.nodejs.org/job/node-test-pull-request/48362/

@lpinca lpinca added the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2022
@nodejs-github-bot nodejs-github-bot removed the commit-queue Add this label to land a pull request using GitHub Actions. label Dec 9, 2022
@nodejs-github-bot nodejs-github-bot merged commit 7d80ca3 into nodejs:main Dec 9, 2022
@nodejs-github-bot
Copy link
Collaborator

Landed in 7d80ca3

@internalsystemerror internalsystemerror mentioned this pull request Dec 10, 2022
Closed
1 task
ErickWendel pushed a commit to ErickWendel/node that referenced this pull request Dec 12, 2022
@npm-cli-bot @ErickWendel
deps: upgrade npm to 9.2.0
e9ca5d3 
PR-URL: nodejs#45780
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos pushed a commit that referenced this pull request Dec 12, 2022
@npm-cli-bot @targos
deps: upgrade npm to 9.2.0
52c4e20 
PR-URL: #45780
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos added a commit that referenced this pull request Dec 12, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
5859103 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.2.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
targos added a commit that referenced this pull request Dec 12, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
4d316b8 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.2.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
@targos targos mentioned this pull request Dec 12, 2022
Merged
@BethGriggs BethGriggs added the baking-for-lts PRs that need to wait before landing in a LTS release. label Dec 12, 2022
targos added a commit that referenced this pull request Dec 13, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
ced2829 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.3.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
targos pushed a commit that referenced this pull request Dec 13, 2022
@npm-cli-bot @targos
deps: upgrade npm to 9.2.0
75dbce9 
PR-URL: #45780
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
targos added a commit that referenced this pull request Dec 13, 2022
@targos
2022-12-13, Version 19.3.0 (Current)
d98cf20 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.3.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
targos added a commit that referenced this pull request Dec 14, 2022
@targos
2022-12-14, Version 19.3.0 (Current)
84aabcf 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.2.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
targos added a commit that referenced this pull request Dec 14, 2022
@targos
2022-12-14, Version 19.3.0 (Current)
b4f8186 
Notable changes:

build:
  * disable v8 snapshot compression by default (Joyee Cheung) #45716
deps:
  * upgrade npm to 9.2.0 (npm team) #45780
doc:
  * add doc-only deprecation for headers/trailers setters (Rich Trott) #45697
  * add Rafael Gonzaga to the TSC (Michael Dawson) #45691
net:
  * (SEMVER-MINOR) add autoSelectFamily and autoSelectFamilyAttemptTimeout options (Paolo Insogna) #44731
src:
  * (SEMVER-MINOR) add uvwasi version (Jithil P Ponnan) #45639
test_runner:
  * (SEMVER-MINOR) add t.after() hook (Colin Ihrig) #45792
  * (SEMVER-MINOR) don't use a symbol for runHook() (Colin Ihrig) #45792
tls:
  * remove trustcor root ca certificates (Ben Noordhuis) #45776

PR-URL: #45831
@derrabus derrabus mentioned this pull request Dec 14, 2022
Closed
@ruyadorno ruyadorno added dont-land-on-v16.x dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. labels Dec 16, 2022
@ruyadorno ruyadorno mentioned this pull request Dec 16, 2022
Merged
@ruyadorno
Copy link
Member

Let's keep track of the dont-land labels until the npm9 update is ready to land on v18.x, ref: #45693 (comment)

@lukekarrys
Copy link
Member

@ruyadorno if it's helpful i can set our release bot to open PRs with those two dont-land labels for now

Trott pushed a commit to Trott/io.js that referenced this pull request Jan 17, 2023
@npm-cli-bot @Trott
deps: upgrade npm to 9.2.0
5648ed1 
PR-URL: nodejs#45780
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@Trott Trott mentioned this pull request Jan 17, 2023
Closed
@MylesBorins MylesBorins removed the dont-land-on-v18.x PRs that should not land on the v18.x-staging branch and should not be released in v18.x. label Jan 17, 2023
juanarbol pushed a commit that referenced this pull request Jan 22, 2023
@npm-cli-bot @juanarbol
deps: upgrade npm to 9.2.0
7599b91 
PR-URL: #45780
Backport-PR-URL: #46230
Reviewed-By: Mohammed Keyvanzadeh <mohammadkeyvanzade94@gmail.com>
Reviewed-By: Luigi Pinca <luigipinca@gmail.com>
Reviewed-By: Colin Ihrig <cjihrig@gmail.com>
Reviewed-By: Yagiz Nizipli <yagiz@nizipli.com>
@juanarbol juanarbol mentioned this pull request Jan 28, 2023
Merged
@richardlau richardlau removed the baking-for-lts PRs that need to wait before landing in a LTS release. label May 8, 2024
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Reviewers

@lpinca lpinca lpinca approved these changes

@anonrig anonrig anonrig approved these changes

@cjihrig cjihrig cjihrig approved these changes

@VoltrexKeyva VoltrexKeyva VoltrexKeyva approved these changes

Assignees
No one assigned
Labels
fast-track PRs that do not need to wait for 48 hours to land. needs-ci PRs that need a full CI run. npm Issues and PRs related to the npm client dependency or the npm registry.
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.

None yet